Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.1.4 #2709

Merged
merged 14 commits into from
Mar 6, 2024
Merged

v3.1.4 #2709

merged 14 commits into from
Mar 6, 2024

Conversation

wpank
Copy link
Contributor

@wpank wpank commented Mar 6, 2024 •
edited
Loading

  • Fixes setting identities:
    • if the account was a superIdentity, a bug in Polkadot.js caused the identity that is returned to not have any subidentites
    • Subidentities are now explicitly fetched to work around the Polkadot.js bug
    • This should fix issues people might have where their rank isn't set right because their identity didn't recognize subidentities
  • Fixes some Nominator status irregularities:
    • Fixes undefined showing for targets under proxy txs
    • Only updates the status for each nominator of constraints checking (candidate validity and scoring) if they are going to nominate (right now it may show a nominator is checking validity when it won't actually nominate because it has a recent nomination tx or pending proxy txs)
    • Adds score to each nominator listed in the proxy section

wpank and others added 7 commits March 5, 2024 03:02
@wpank
Merge pull request #2700 from w3f/will-v3.1.3
59ac1da 
Adjust shouldNominate
@wpank
Merge pull request #2701 from w3f/will-v3.1.3
352f574 
add tests, update swagger endpoints, use enums
@wpank
Merge pull request #2702 from w3f/will-v3.1.3
c11f491 
update client check / monitor constants
@wpank
Merge pull request #2703 from w3f/will-v3.1.3
458fdeb 
add client and adjust candidate gateway endpoint
@wpank
Merge pull request #2705 from w3f/will-v3.1.3
0c5a110 
Remove old db records
adjust nominator status updates
2a702a7
add score to proxy txs ui
c0db0e0
@wpank wpank marked this pull request as ready for review March 6, 2024 14:37
@wpank wpank requested a review from ironoa March 6, 2024 14:37
@wpank
Merge pull request #2710 from w3f/will-v3.1.4
a1d23ff 
Adjust Proxy Tx Nominator Status
@wpank wpank merged commit dc5f4c9 into master Mar 6, 2024
12 checks passed
@wpank wpank deleted the will-v3.1.4 branch March 6, 2024 18:02
@ironoa
Copy link
Contributor

ironoa commented Mar 7, 2024 •
edited
Loading 

  * if the account was a superIdentity, a bug in Polkadot.js caused the identity that is returned to not have any subidentites

should we open an issue on polkadot.js ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironoa ironoa ironoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpank @ironoa